fix(logging.handlers.SocketHandler): properly handle unset port #127398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: timo eisenmann <[email protected]> co-authored-by: veselin vasilev <[email protected]> co-authored-by: oluf lorenzen <[email protected]>
Changes: - Before the backoff/retry functionality did nothing. - Now it retries until a certain amount of retries or a time limit. - The values of backoff/retry are accessible. - Same as the timeout for the initial socket creation. Co-authored-by: timo eisenmann <[email protected]> Co-authored-by: veselin vasilev <[email protected]> Co-authored-by: oluf lorenzen <[email protected]>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored-by: timo eisenmann [email protected]
co-authored-by: veselin vasilev [email protected]
co-authored-by: oluf lorenzen [email protected]<!--
Thanks for your contribution!
Please read this comment in its entirety. It's quite important.
Pull Request title
It should be in the following format:
Where: gh-NNNNN refers to the GitHub issue number.
Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.
Backport Pull Request title
If this is a backport PR (PR made against branches other than
main),please ensure that the PR title is in the following format:
Where: [X.Y] is the branch name, e.g. [3.6].
GH-NNNN refers to the PR number from
main.-->